[llvm] [AArch64] Lower for power of 2 signed divides with scalar type (PR #97879)

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 01:41:50 PDT 2024


https://github.com/david-arm commented:

Thanks for the fix! I personally would prefer to see the patch split up so that we have one PR for fixing https://github.com/llvm/llvm-project/issues/97821 and another PR for the additional optimisations you are adding in buildSDIVPow2WithCMov. This makes it more obvious which code change is having a particular effect on the tests. Also #97821 feels to me like an actual AArch64 backend bug that should be fixed on it's own. The problem with putting all the changes together in one patch is that if the patch gets reverted in future for some reason then we still don't have the bug fix.

https://github.com/llvm/llvm-project/pull/97879


More information about the llvm-commits mailing list