[llvm] [PAC][CodeGen][ELF][AArch64] Support signed GOT (PR #96164)

Daniil Kovalev via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 14:15:27 PDT 2024


================
@@ -24,6 +24,7 @@ namespace llvm {
 class AArch64MCExpr : public MCTargetExpr {
 public:
   enum VariantKind {
+    // clang-format off
----------------
kovdan01 wrote:

Allowing clang-format here breaks custom formatting which IMHO is very nice and helps understanding.

Without clang-format:

```
    VK_CALL              = VK_ABS,
    VK_ABS_PAGE          = VK_ABS      | VK_PAGE,
    VK_ABS_PAGE_NC       = VK_ABS      | VK_PAGE    | VK_NC,
    VK_ABS_G3            = VK_ABS      | VK_G3,
    VK_ABS_G2            = VK_ABS      | VK_G2,
    VK_ABS_G2_S          = VK_SABS     | VK_G2,
    VK_ABS_G2_NC         = VK_ABS      | VK_G2      | VK_NC,
    VK_ABS_G1            = VK_ABS      | VK_G1,
    VK_ABS_G1_S          = VK_SABS     | VK_G1,
    VK_ABS_G1_NC         = VK_ABS      | VK_G1      | VK_NC,
```

With clang-format:

```
    VK_CALL = VK_ABS,
    VK_ABS_PAGE = VK_ABS | VK_PAGE,
    VK_ABS_PAGE_NC = VK_ABS | VK_PAGE | VK_NC,
    VK_ABS_G3 = VK_ABS | VK_G3,
    VK_ABS_G2 = VK_ABS | VK_G2,
    VK_ABS_G2_S = VK_SABS | VK_G2,
    VK_ABS_G2_NC = VK_ABS | VK_G2 | VK_NC,
    VK_ABS_G1 = VK_ABS | VK_G1,
    VK_ABS_G1_S = VK_SABS | VK_G1,
    VK_ABS_G1_NC = VK_ABS | VK_G1 | VK_NC,
```

Can we leave `// clang-format off` here? Or is there probably a better way to teach clang-format how to keep such custom formatting?

https://github.com/llvm/llvm-project/pull/96164


More information about the llvm-commits mailing list