[llvm] [PAC][CodeGen][ELF][AArch64] Support signed GOT (PR #96164)

Daniil Kovalev via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 14:13:14 PDT 2024


================
@@ -30,6 +30,7 @@ const AArch64MCExpr *AArch64MCExpr::create(const MCExpr *Expr, VariantKind Kind,
 }
 
 StringRef AArch64MCExpr::getVariantKindName() const {
+  // clang-format off
----------------
kovdan01 wrote:

Allowing clang-format here leads to inconsistent formatting between new and old case labels - see a fragment below

```
  case VK_TLSDESC_PAGE:        return ":tlsdesc:";
  case VK_SECREL_LO12:         return ":secrel_lo12:";
  case VK_SECREL_HI12:         return ":secrel_hi12:";
  case VK_GOT_AUTH:
    return ":got_auth:";
  case VK_GOT_AUTH_PAGE:
    return ":got_auth:";
  case VK_GOT_AUTH_LO12:
    return ":got_auth_lo12:";
```

To make things consistent, I can format old cases the way clang-format likes (with return on new line). This should probably be done as a separate patch in order not to mess functionality and refactoring changes - if so, it's probably OK to leave `// clang-format off` until the follow-up refactoring patch merges. Please let me know your thoughts on this.

https://github.com/llvm/llvm-project/pull/96164


More information about the llvm-commits mailing list