[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:36:03 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64be-linux-test-suite` running on `ppc64be-clang-test-suite` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/176/builds/434

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/SplitKit.h:19,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/InlineSpiller.cpp:14:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/DenseMap.h: In member function ‘void llvm::DenseMap<KeyT, ValueT, KeyInfoT, BucketT>::grow(unsigned int) [with KeyT = llvm::Register; ValueT = llvm::SmallSetVector<llvm::Register, 16>; KeyInfoT = llvm::DenseMapInfo<llvm::Register>; BucketT = llvm::detail::DenseMapPair<llvm::Register, llvm::SmallSetVector<llvm::Register, 16> >]’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/DenseMap.h:845:8: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  845 |   void grow(unsigned AtLeast) {
      |        ^~~~
52.912 [4679/40/1036] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LocalStackSlotAllocation.cpp.o
55.975 [4678/40/1037] Building AMDGPUGenCallingConv.inc...
56.316 [4677/40/1038] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveIntervals.cpp.o
56.990 [4676/40/1039] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o 
ccache /opt/rh/devtoolset-11/root/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/lib/CodeGen -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/MachineBlockPlacement.cpp
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/MachineBlockPlacement.cpp:44:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
57.018 [4676/39/1040] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveVariables.cpp.o
57.208 [4676/38/1041] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveDebugVariables.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:13,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachineFunction.h:20,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachineFunctionPass.h:21,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/LiveDebugVariables.h:23,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/LiveDebugVariables.cpp:21:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/SmallVector.h: In function ‘llvm::SmallVectorImpl<T>& llvm::SmallVectorImpl<T>::operator=(llvm::SmallVectorImpl<T>&&) [with T = std::pair<llvm::LiveInterval*, const llvm::VNInfo*>]’:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/SmallVector.h:608:22: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  608 |     this->Size = RHS.Size;
      |                  ~~~~^~~~
57.599 [4676/37/1042] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o 
ccache /opt/rh/devtoolset-11/root/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/lib/CodeGen -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/build/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachineDomTreeUpdater.h:21,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp:14:
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
57.883 [4676/36/1043] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
57.899 [4676/35/1044] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFunctionPrinterPass.cpp.o
59.246 [4676/34/1045] Building AMDGPUGenPostLegalizeGICombiner.inc...
59.423 [4676/33/1046] Building AMDGPUGenMCPseudoLowering.inc...
59.435 [4676/32/1047] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockFrequencyInfo.cpp.o
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:13,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachineFunction.h:20,
                 from /home/buildbots/llvm-external-buildbots/workers/ppc64be-clang-test-suite/clang-ppc64be-test-suite/llvm-project/llvm/include/llvm/CodeGen/MachineFunctionPass.h:21,

```

https://github.com/llvm/llvm-project/pull/95369