[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:35:57 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-rel-x86-64` running on `ml-opt-rel-x86-64-b1` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/185/builds/718

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
134.931 [1167/64/2410] Building CXX object lib/Target/AMDGPU/MCTargetDesc/CMakeFiles/LLVMAMDGPUDesc.dir/AMDGPUMCExpr.cpp.o
134.985 [1166/64/2411] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FixupStatepointCallerSaved.cpp.o
135.007 [1165/64/2412] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveRangeShrink.cpp.o
135.699 [1164/64/2413] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/BranchFolding.cpp.o
135.974 [1163/64/2414] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveRangeCalc.cpp.o
136.006 [1162/64/2415] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/NonRelocatableStringpool.cpp.o
136.081 [1161/64/2416] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/IfConversion.cpp.o
137.773 [1160/64/2417] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InlineSpiller.cpp.o
138.174 [1159/64/2418] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DwarfEHPrepare.cpp.o
138.233 [1158/64/2419] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_HAVE_TF_AOT_REGALLOCEVICTMODEL -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-rel-x86-64-b1/build/lib/CodeGen -I/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/lib/CodeGen -I/var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include -I/b/ml-opt-rel-x86-64-b1/build/include -I/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -c /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp
In file included from /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachineDomTreeUpdater.h:21,
                 from /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp:14:
/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
138.731 [1158/63/2420] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
138.837 [1158/62/2421] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFrameInfo.cpp.o
138.890 [1158/61/2422] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InterleavedLoadCombinePass.cpp.o
138.913 [1158/60/2423] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveRangeEdit.cpp.o
139.326 [1158/59/2424] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineLICM.cpp.o
141.227 [1158/58/2425] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveVariables.cpp.o
141.259 [1158/57/2426] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineOptimizationRemarkEmitter.cpp.o
141.341 [1158/56/2427] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineInstr.cpp.o
141.762 [1158/55/2428] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCombiner.cpp.o
141.806 [1158/54/2429] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineModuleSlotTracker.cpp.o
142.289 [1158/53/2430] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineLoopUtils.cpp.o
142.586 [1158/52/2431] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_HAVE_TF_AOT_REGALLOCEVICTMODEL -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-rel-x86-64-b1/build/lib/CodeGen -I/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/lib/CodeGen -I/var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include -I/b/ml-opt-rel-x86-64-b1/build/include -I/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o -c /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/lib/CodeGen/MachinePostDominators.cpp
In file included from /b/ml-opt-rel-x86-64-b1/llvm-project/llvm/lib/CodeGen/MachinePostDominators.cpp:14:
/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/b/ml-opt-rel-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
142.813 [1158/51/2432] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCheckDebugify.cpp.o
143.021 [1158/50/2433] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ComplexDeinterleavingPass.cpp.o
143.693 [1158/49/2434] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDominanceFrontier.cpp.o
143.793 [1158/48/2435] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRYamlMapping.cpp.o
144.053 [1158/47/2436] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MBFIWrapper.cpp.o
144.386 [1158/46/2437] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineModuleInfo.cpp.o
144.400 [1158/45/2438] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveIntervals.cpp.o
144.406 [1158/44/2439] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSizeOpts.cpp.o

```

https://github.com/llvm/llvm-project/pull/95369