[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:32:46 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-rel-assert` running on `linaro-flang-aarch64-rel-assert` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/29/builds/486

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
16.548 [5641/16/1094] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrintingPass.cpp.o
16.573 [5641/15/1095] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MacroFusion.cpp.o
16.763 [5641/14/1096] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PHIEliminationUtils.cpp.o
16.786 [5641/13/1097] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PeepholeOptimizer.cpp.o
16.893 [5637/16/1098] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ProcessImplicitDefs.cpp.o
16.902 [5637/15/1099] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PostRAHazardRecognizer.cpp.o
16.935 [5637/14/1100] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PHIElimination.cpp.o
16.981 [5637/13/1101] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PostRASchedulerList.cpp.o
17.016 [5630/19/1102] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PreISelIntrinsicLowering.cpp.o
17.046 [5630/18/1103] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o 
/usr/local/bin/c++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/build/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp
In file included from ../llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp:14:
In file included from ../llvm-project/llvm/include/llvm/CodeGen/MachineDomTreeUpdater.h:21:
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: constructor cannot be redeclared
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous definition is here
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^
1 error generated.
17.246 [5630/17/1104] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PseudoProbeInserter.cpp.o
17.277 [5630/16/1105] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PseudoSourceValue.cpp.o
17.287 [5630/15/1106] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RDFGraph.cpp.o
17.293 [5630/14/1107] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/PrologEpilogInserter.cpp.o
17.335 [5630/13/1108] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ReachingDefAnalysis.cpp.o
17.350 [5630/12/1109] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RDFRegisters.cpp.o
17.372 [5630/11/1110] Building AArch64GenInstrInfo.inc...
17.413 [5630/10/1111] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RDFLiveness.cpp.o
17.442 [5630/9/1112] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RegAllocBasic.cpp.o
17.445 [5630/8/1113] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RegAllocBase.cpp.o
17.462 [5630/7/1114] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RegAllocEvictionAdvisor.cpp.o
17.548 [5630/6/1115] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/RegAllocFast.cpp.o
20.960 [5630/5/1116] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o 
/usr/local/bin/c++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/build/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/lib/CodeGen/MachinePostDominators.cpp
In file included from ../llvm-project/llvm/lib/CodeGen/MachinePostDominators.cpp:14:
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: constructor cannot be redeclared
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous definition is here
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^
1 error generated.
23.634 [5630/4/1117] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o 
/usr/local/bin/c++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/build/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-rel-assert/llvm-project/llvm/lib/CodeGen/MachineBlockPlacement.cpp
In file included from ../llvm-project/llvm/lib/CodeGen/MachineBlockPlacement.cpp:44:
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: constructor cannot be redeclared

```

https://github.com/llvm/llvm-project/pull/95369