[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:32:36 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `llvm` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/676

Here is the relevant piece of the build log for the reference:
```
Step 6 (build-unified-tree) failure: build (failure)
...
[1390/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCombiner.cpp.obj
[1391/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\NonRelocatableStringpool.cpp.obj
[1392/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominanceFrontier.cpp.obj
[1393/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\InterleavedLoadCombinePass.cpp.obj
[1394/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCFGPrinter.cpp.obj
[1395/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\IfConversion.cpp.obj
[1396/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominators.cpp.obj
[1397/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineSizeOpts.cpp.obj
[1398/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ComplexDeinterleavingPass.cpp.obj
[1399/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen\MachinePostDominators.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1400/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineOperand.cpp.obj
[1401/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveDebugVariables.cpp.obj
[1402/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineRegionInfo.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen\MachineRegionInfo.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1403/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineLateInstrsCleanup.cpp.obj
[1404/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MBFIWrapper.cpp.obj
[1405/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\CodeGenPrepare.cpp.obj
[1406/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFrameInfo.cpp.obj
[1407/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveStacks.cpp.obj
[1408/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCSE.cpp.obj
[1409/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen\MachineBlockPlacement.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1410/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCheckDebugify.cpp.obj
[1411/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveVariables.cpp.obj
[1412/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen\MachineDomTreeUpdater.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1413/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\PHIEliminationUtils.cpp.obj
[1414/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCopyPropagation.cpp.obj
[1415/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineSink.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSink.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineSink.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\lib\CodeGen\MachineSink.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1416/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunctionPrinterPass.cpp.obj
[1417/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineModuleInfo.cpp.obj
[1418/4660] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MLRegAllocPriorityAdvisor.cpp.obj

```

https://github.com/llvm/llvm-project/pull/95369