[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:32:09 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-nvptx64-nvidia-win` running on `as-builder-8` while building `llvm` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/330

Here is the relevant piece of the build log for the reference:
```
Step 6 (build-unified-tree) failure: build (failure)
...
[603/2597] Building X86GenAsmMatcher.inc...
[604/2597] Building X86GenDisassemblerTables.inc...
[605/2597] Building X86GenFastISel.inc...
[606/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\NonRelocatableStringpool.cpp.obj
[607/2597] Building X86GenGlobalISel.inc...
[608/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBranchProbabilityInfo.cpp.obj
[609/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\AllocationOrder.cpp.obj
[610/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\EdgeBundles.cpp.obj
[611/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LoopTraversal.cpp.obj
[612/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1436~1.325\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\lib\CodeGen -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\include -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\lib\CodeGen\MachinePostDominators.cpp
C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[613/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunctionPrinterPass.cpp.obj
[614/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1436~1.325\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\lib\CodeGen -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\include -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\lib\CodeGen\MachineDomTreeUpdater.cpp
C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[615/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MBFIWrapper.cpp.obj
[616/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveRegUnits.cpp.obj
[617/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveIntervalUnion.cpp.obj
[618/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LivePhysRegs.cpp.obj
[619/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\DetectDeadLanes.cpp.obj
[620/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\EHContGuardCatchret.cpp.obj
[621/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MIRYamlMapping.cpp.obj
[622/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\FuncletLayout.cpp.obj
[623/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\CFGuardLongjmp.cpp.obj
[624/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineRegionInfo.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1436~1.325\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\lib\CodeGen -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\include -IC:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\lib\CodeGen\MachineRegionInfo.cpp
C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[625/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\BreakFalseDeps.cpp.obj
[626/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\InterferenceCache.cpp.obj
[627/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\IndirectBrExpandPass.cpp.obj
[628/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\BasicBlockSectionsProfileReader.cpp.obj
[629/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\DeadMachineInstructionElim.cpp.obj
[630/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LazyMachineBlockFrequencyInfo.cpp.obj
[631/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\FEntryInserter.cpp.obj
[632/2597] Building X86GenDAGISel.inc...
[633/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\BranchRelaxation.cpp.obj
[634/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MIRPrintingPass.cpp.obj
[635/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveStacks.cpp.obj
[636/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\FaultMaps.cpp.obj
[637/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ExecutionDomainFix.cpp.obj
[638/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveIntervalCalc.cpp.obj
[639/2597] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ExpandPostRAPseudos.cpp.obj

```

https://github.com/llvm/llvm-project/pull/95369