[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:32:05 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-latest-gcc` running on `linaro-flang-aarch64-latest-gcc` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/435

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
17.171 [5431/71/1580] Building AArch64GenInstrInfo.inc...
17.201 [5431/70/1581] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LocalStackSlotAllocation.cpp.o
17.383 [5431/69/1582] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveRangeShrink.cpp.o
17.418 [5426/73/1583] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MultiHazardRecognizer.cpp.o
17.693 [5426/72/1584] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveRangeCalc.cpp.o
17.784 [5426/71/1585] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFunctionPrinterPass.cpp.o
17.961 [5426/70/1586] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DwarfEHPrepare.cpp.o
18.050 [5418/77/1587] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/NonRelocatableStringpool.cpp.o
18.156 [5418/76/1588] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveInterval.cpp.o
18.275 [5418/75/1589] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp
In file included from ../llvm-project/llvm/include/llvm/CodeGen/MachineDomTreeUpdater.h:21,
                 from ../llvm-project/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp:14:
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
18.834 [5418/74/1590] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InterleavedAccessPass.cpp.o
18.971 [5418/73/1591] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
19.322 [5418/72/1592] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCheckDebugify.cpp.o
19.527 [5418/71/1593] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineOptimizationRemarkEmitter.cpp.o
19.556 [5418/70/1594] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FixupStatepointCallerSaved.cpp.o
19.658 [5418/69/1595] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineModuleSlotTracker.cpp.o
19.834 [5418/68/1596] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DFAPacketizer.cpp.o
19.875 [5418/67/1597] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineLoopUtils.cpp.o
19.940 [5418/66/1598] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InterleavedLoadCombinePass.cpp.o
20.048 [5418/65/1599] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCombiner.cpp.o
20.116 [5418/64/1600] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineInstrBundle.cpp.o
20.122 [5418/63/1601] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InlineSpiller.cpp.o
20.177 [5418/62/1602] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/lib/CodeGen/MachineBlockPlacement.cpp
In file included from ../llvm-project/llvm/lib/CodeGen/MachineBlockPlacement.cpp:44:
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
../llvm-project/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
20.177 [5418/61/1603] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MBFIWrapper.cpp.o
20.184 [5418/60/1604] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineSizeOpts.cpp.o
20.204 [5418/59/1605] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ComplexDeinterleavingPass.cpp.o
20.424 [5418/58/1606] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/lib/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/llvm-project/llvm/lib/CodeGen/MachinePostDominators.cpp
In file included from ../llvm-project/llvm/lib/CodeGen/MachinePostDominators.cpp:14:

```

https://github.com/llvm/llvm-project/pull/95369