[llvm] a9ac319 - [MC] Make MCELFStreamer::finishImpl final

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 23 21:26:32 PDT 2024


Author: Fangrui Song
Date: 2024-06-23T21:26:27-07:00
New Revision: a9ac31910db3975d5e92a6265ab29dafd6a4691d

URL: https://github.com/llvm/llvm-project/commit/a9ac31910db3975d5e92a6265ab29dafd6a4691d
DIFF: https://github.com/llvm/llvm-project/commit/a9ac31910db3975d5e92a6265ab29dafd6a4691d.diff

LOG: [MC] Make MCELFStreamer::finishImpl final

This function is final after efdb91e1daba502481f8eab6116e3595766e2300.
Target-specific code should override MCTargetStreamer::finish instead,
e.g. AArch64TargetELFStreamer::finish
(fec1b6f9d3cf5347b67ffb2078c995eb496acf47).

Added: 
    

Modified: 
    llvm/include/llvm/MC/MCELFStreamer.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/MC/MCELFStreamer.h b/llvm/include/llvm/MC/MCELFStreamer.h
index 44c585a74f15d..1cd64e406d4d0 100644
--- a/llvm/include/llvm/MC/MCELFStreamer.h
+++ b/llvm/include/llvm/MC/MCELFStreamer.h
@@ -80,7 +80,9 @@ class MCELFStreamer : public MCObjectStreamer {
   void emitCGProfileEntry(const MCSymbolRefExpr *From,
                           const MCSymbolRefExpr *To, uint64_t Count) override;
 
-  void finishImpl() override;
+  // This is final. Override MCTargetStreamer::finish instead for
+  // target-specific code.
+  void finishImpl() final;
 
   void emitBundleAlignMode(Align Alignment) override;
   void emitBundleLock(bool AlignToEnd) override;


        


More information about the llvm-commits mailing list