[llvm] AMDGPU: Remove an outdated TODO (PR #96446)
Nicolai Hähnle via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 23 15:12:09 PDT 2024
https://github.com/nhaehnle created https://github.com/llvm/llvm-project/pull/96446
We have a fixed calling convention for stack pointer and frame pointer, we shouldn't try to shift anything around.
>From 78ccfba9aded492d8647ea503c4da8cf79471cd7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicolai=20H=C3=A4hnle?= <nicolai.haehnle at amd.com>
Date: Sun, 23 Jun 2024 18:44:26 +0200
Subject: [PATCH] AMDGPU: Remove an outdated TODO
We have a fixed calling convention for stack pointer and frame pointer,
we shouldn't try to shift anything around.
---
llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
index 072c5aedc220b..74f6fd64b473e 100644
--- a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
@@ -83,7 +83,6 @@ SIMachineFunctionInfo::SIMachineFunctionInfo(const Function &F,
if (CC != CallingConv::AMDGPU_Gfx)
ArgInfo = AMDGPUArgumentUsageInfo::FixedABIFunctionInfo;
- // TODO: Pick a high register, and shift down, similar to a kernel.
FrameOffsetReg = AMDGPU::SGPR33;
StackPtrOffsetReg = AMDGPU::SGPR32;
More information about the llvm-commits
mailing list