[llvm] AMDGPU: Start fixing inconsistencies in usage of SubtargetPredicate (PR #96337)

[Stanislav Mekhanoshin via llvm-commits]

================
@@ -1227,12 +1227,12 @@ defm BUFFER_ATOMIC_PK_ADD_F16 : MUBUF_Pseudo_Atomics_NO_RTN <
   "buffer_atomic_pk_add_f16", VGPR_32, v2f16
 >;
 
-let OtherPredicates = [HasAtomicFaddRtnInsts] in
+let SubtargetPredicate = HasAtomicFaddRtnInsts in
----------------
rampitec wrote:

Is there any logic here? Above OtherPredicates is used for 'HasSomething' condition, here it is used as a SubtargetPredicate. I.e. I do not see it is making anything better or more consistent.

https://github.com/llvm/llvm-project/pull/96337