[llvm] [offload][runtimes] Forward user-provided system configuration. (PR #96303)
Joseph Huber via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 21 11:17:09 PDT 2024
jhuber6 wrote:
> > > [3de162f](https://github.com/llvm/llvm-project/commit/3de162fee44376b3857c73958d656f76b17e50f5) sets it to `CUDAToolkit_BIN_DIR`, but the meaning it previously had (the path passed to `clang --cuda-path`) would be `CUDAToolkit_LIBRARY_ROOT`.
> >
> >
> > No, it takes the directory of `opt/cuda/bin` which is `opt/cuda` for example.
>
> OK, it does `get_filename_component` of `CUDAToolkit_BIN_DIR`, but would be unnecessary since `CUDAToolkit_LIBRARY_ROOT` already contains that path. `CUDA_LIBDIR` is also the same as `CUDAToolkit_LIBRARY_DIR`. See https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html#result-variables
Oh yeah, now I remember. I used the old one because that came in CMake 3.18 so it was the only solution before we moved to 3.20.
https://github.com/llvm/llvm-project/pull/96303
More information about the llvm-commits
mailing list