[llvm] [Inliner] Handle CGSCC changes from #94815 (PR #96274)

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 21 07:42:42 PDT 2024


================
@@ -206,23 +206,18 @@ void MLInlineAdvisor::onPassEntry(LazyCallGraph::SCC *LastSCC) {
   // care about the nature of the Edge (call or ref). `FunctionLevels`-wise, we
   // record them at the same level as the original node (this is a choice, may
   // need revisiting).
-  NodeCount -= static_cast<int64_t>(NodesInLastSCC.size());
   while (!NodesInLastSCC.empty()) {
     const auto *N = *NodesInLastSCC.begin();
+    assert(!N->isDead());
----------------
mtrofin wrote:

could you add a note in the comment blurb above the `while`, to the "The cgscc pass manager rules", saying "Nodes are never deleted"? (IIUC that's now the case, right?)


https://github.com/llvm/llvm-project/pull/96274


More information about the llvm-commits mailing list