[llvm] f12655a - [HLSLResource] Don't include Metadata.h (NFC)

[Nikita Popov via llvm-commits]

Author: Nikita Popov
Date: 2024-06-21T13:02:47+02:00
New Revision: f12655ac1e0b036e354d4484f34409bd1438a69c

URL: https://github.com/llvm/llvm-project/commit/f12655ac1e0b036e354d4484f34409bd1438a69c
DIFF: https://github.com/llvm/llvm-project/commit/f12655ac1e0b036e354d4484f34409bd1438a69c.diff

LOG: [HLSLResource] Don't include Metadata.h (NFC)

This is only used for a single assert, so move it out of line.
This avoids a dependency on Metadata.h from large parts of clang.

Added: 
    

Modified: 
    llvm/include/llvm/Frontend/HLSL/HLSLResource.h
    llvm/lib/Frontend/HLSL/HLSLResource.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Frontend/HLSL/HLSLResource.h b/llvm/include/llvm/Frontend/HLSL/HLSLResource.h
index edfcbda0a3bb3..5c22d2ac02031 100644
--- a/llvm/include/llvm/Frontend/HLSL/HLSLResource.h
+++ b/llvm/include/llvm/Frontend/HLSL/HLSLResource.h
@@ -13,11 +13,11 @@
 #ifndef LLVM_FRONTEND_HLSL_HLSLRESOURCE_H
 #define LLVM_FRONTEND_HLSL_HLSLRESOURCE_H
 
-#include "llvm/IR/Metadata.h"
 #include "llvm/Support/DXILABI.h"
 
 namespace llvm {
 class GlobalVariable;
+class MDNode;
 
 namespace hlsl {
 
@@ -38,10 +38,7 @@ class FrontendResource {
   MDNode *Entry;
 
 public:
-  FrontendResource(MDNode *E) : Entry(E) {
-    assert(Entry->getNumOperands() == 6 && "Unexpected metadata shape");
-  }
-
+  FrontendResource(MDNode *E);
   FrontendResource(GlobalVariable *GV, ResourceKind RK, ElementType ElTy,
                    bool IsROV, uint32_t ResIndex, uint32_t Space);
 

diff  --git a/llvm/lib/Frontend/HLSL/HLSLResource.cpp b/llvm/lib/Frontend/HLSL/HLSLResource.cpp
index bcdbe5eadc69e..dd2b0b60bc19b 100644
--- a/llvm/lib/Frontend/HLSL/HLSLResource.cpp
+++ b/llvm/lib/Frontend/HLSL/HLSLResource.cpp
@@ -51,6 +51,10 @@ uint32_t FrontendResource::getSpace() {
       ->getLimitedValue();
 }
 
+FrontendResource::FrontendResource(MDNode *E) : Entry(E) {
+  assert(Entry->getNumOperands() == 6 && "Unexpected metadata shape");
+}
+
 FrontendResource::FrontendResource(GlobalVariable *GV, ResourceKind RK,
                                    ElementType ElTy, bool IsROV,
                                    uint32_t ResIndex, uint32_t Space) {