[llvm] [BOLT][DWARF] Refactor updateDWARFObjectAddressRanges (PR #96006)
Alexander Yermolovich via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 10:32:36 PDT 2024
================
@@ -1270,10 +1279,14 @@ void DWARFRewriter::updateDWARFObjectAddressRanges(
}
if (RangesBaseInfo) {
- DIEBldr.replaceValue(&Die, RangesBaseInfo.getAttribute(),
- RangesBaseInfo.getForm(),
- DIEInteger(static_cast<uint32_t>(*RangesBase)));
- RangesBase = std::nullopt;
+ if (RangesBaseInfo.getAttribute() == dwarf::DW_AT_GNU_ranges_base) {
+ UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die;
----------------
ayermolo wrote:
Not setting RangesBase = std::nullopt;
Can you check why this isn't necessary anymore. If it's a bug add a test to cover this.
https://github.com/llvm/llvm-project/pull/96006
More information about the llvm-commits
mailing list