[llvm] [NFC][AMDGPU] Do not flush after printing every instruction (PR #95237)
Pierre van Houtryve via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 05:26:42 PDT 2024
Pierre-vh wrote:
> Easy, but probably not ideal from performance and disk wearing perspectives.
Flushing too often - just because some tests aren't updated - is very likely way worse for performance (and your disk's lifespan). When I removed this flush call after every instruction, It reduced one build's time by almost 10%. 8 seconds wasted doing thousand of premature writes to disk.
> So it's necessary to update the tests that employ that then.
Yes, because it's easy to fix and it's not a good pattern.
https://github.com/llvm/llvm-project/pull/95237
More information about the llvm-commits
mailing list