[llvm] [llvm-readobj][ELF] Fix broken JSON output with --dynamic-table (PR #95976)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 00:50:27 PDT 2024
https://github.com/jh7370 commented:
Per the LLVM PR guidelines, please avoid force pushes on your branch: they make it harder to review, because you can no longer see what's changed since the previous version. If rebasing is necessary, you can use a merge commit from the base branch. When you squash and merge upon submission, the merge commit (and any fixup commits) will disappear.
I also prefer it if you don't "Resolve Conversation" on threads I've started, because I use this to track comments that I'm happy have been satisfactorily resolved (you'd be surprised how often people click "Resolve Conversation" when they haven't made the requested change, or they've made it incorrectly. See https://discourse.llvm.org/t/rfc-github-pr-resolve-conversation-button/73178 for more context.
https://github.com/llvm/llvm-project/pull/95976
More information about the llvm-commits
mailing list