[llvm] [llvm-mca] Use llvm::erase_if (NFC) (PR #96029)

[Peter Waller via llvm-commits]

https://github.com/peterwaller-arm approved this pull request.

Thanks for tagging me on review.

https://github.com/llvm/llvm-project/pull/96029