[llvm] [SPIR-V] Add __spirv_ wrapper to the OpAtomicExchange instruction (PR #95961)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 10:58:58 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-spir-v

Author: Vyacheslav Levytskyy (VyacheslavLevytskyy)

<details>
<summary>Changes</summary>

This PR adds __spirv_ wrapper to the OpAtomicExchange instruction. A new test case is added for the change introduced.

---
Full diff: https://github.com/llvm/llvm-project/pull/95961.diff


2 Files Affected:

- (modified) llvm/lib/Target/SPIRV/SPIRVBuiltins.td (+1) 
- (added) llvm/test/CodeGen/SPIRV/AtomicExchange.ll (+96) 


``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVBuiltins.td b/llvm/lib/Target/SPIRV/SPIRVBuiltins.td
index d93756cc67c9c..2b8e6d856686a 100644
--- a/llvm/lib/Target/SPIRV/SPIRVBuiltins.td
+++ b/llvm/lib/Target/SPIRV/SPIRVBuiltins.td
@@ -533,6 +533,7 @@ defm : DemangledNativeBuiltin<"__spirv_AtomicAnd", OpenCL_std, Atomic, 4, 4, OpA
 defm : DemangledNativeBuiltin<"atomic_exchange", OpenCL_std, Atomic, 2, 4, OpAtomicExchange>;
 defm : DemangledNativeBuiltin<"atomic_exchange_explicit", OpenCL_std, Atomic, 2, 4, OpAtomicExchange>;
 defm : DemangledNativeBuiltin<"AtomicEx__spirv_change", OpenCL_std, Atomic, 2, 4, OpAtomicExchange>;
+defm : DemangledNativeBuiltin<"__spirv_AtomicExchange", OpenCL_std, Atomic, 4, 4, OpAtomicExchange>;
 defm : DemangledNativeBuiltin<"atomic_work_item_fence", OpenCL_std, Atomic, 1, 3, OpMemoryBarrier>;
 defm : DemangledNativeBuiltin<"__spirv_MemoryBarrier", OpenCL_std, Atomic, 2, 2, OpMemoryBarrier>;
 defm : DemangledNativeBuiltin<"atomic_fetch_add", OpenCL_std, Atomic, 2, 4, OpAtomicIAdd>;
diff --git a/llvm/test/CodeGen/SPIRV/AtomicExchange.ll b/llvm/test/CodeGen/SPIRV/AtomicExchange.ll
new file mode 100644
index 0000000000000..69b91571b60a8
--- /dev/null
+++ b/llvm/test/CodeGen/SPIRV/AtomicExchange.ll
@@ -0,0 +1,96 @@
+; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+
+; CHECK-DAG: %[[#Long:]] = OpTypeInt 64 0
+; CHECK-COUNT-9: %[[#]] = OpAtomicExchange %[[#Long]] %[[#]] %[[#]] %[[#]] %[[#]]
+
+%Type1 = type { i64 }
+%Type2 = type { ptr addrspace(4) }
+
+define linkonce_odr dso_local spir_func void @f1() {
+entry:
+  %a = alloca %Type1, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePyN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEy(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 3)
+  ret void
+}
+
+define linkonce_odr dso_local spir_func void @f2() {
+entry:
+  %a = alloca %Type1, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePxN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEx(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 3)
+  ret void
+}
+
+define linkonce_odr dso_local spir_func void @f3() {
+entry:
+  %a = alloca %Type1, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 3)
+  ret void
+}
+
+define linkonce_odr dso_local spir_func void @f4() {
+entry:
+  %a = alloca %Type1, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePlN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEl(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 3)
+  ret void
+}
+
+
+define linkonce_odr dso_local spir_func void @f5() {
+entry:
+  %a = alloca %Type2, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 %p)
+  ret void
+}
+
+define linkonce_odr dso_local spir_func void @f6() {
+entry:
+  %a = alloca %Type2, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 %p)
+  ret void
+}
+
+define linkonce_odr dso_local spir_func void @f7() {
+entry:
+  %a = alloca %Type2, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 %p)
+  ret void
+}
+
+define linkonce_odr dso_local spir_func void @f8() {
+entry:
+  %a = alloca %Type2, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 %p)
+  ret void
+}
+
+; Function Attrs: convergent mustprogress norecurse nounwind
+define linkonce_odr dso_local spir_func void @f9() {
+entry:
+  %a = alloca %Type2, align 8
+  %a.ascast = addrspacecast ptr %a to ptr addrspace(4)
+  %p = ptrtoint ptr addrspace(4) %a.ascast to i64
+  %res = call spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4) %a.ascast, i32 0, i32 912, i64 %p)
+  ret void
+}
+
+declare dso_local spir_func i64 @_Z22__spirv_AtomicExchangePyN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEy(ptr addrspace(4), i32, i32, i64)
+declare dso_local spir_func i64 @_Z22__spirv_AtomicExchangePxN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEx(ptr addrspace(4), i32, i32, i64)
+declare dso_local spir_func i64 @_Z22__spirv_AtomicExchangePmN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEm(ptr addrspace(4), i32, i32, i64)
+declare dso_local spir_func i64 @_Z22__spirv_AtomicExchangePlN5__spv5Scope4FlagENS0_19MemorySemanticsMask4FlagEl(ptr addrspace(4), i32, i32, i64)

``````````

</details>


https://github.com/llvm/llvm-project/pull/95961


More information about the llvm-commits mailing list