[llvm] [MachineLICM] Workaround - apply RegMasks conservatively (PR #95926)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 07:56:12 PDT 2024


================
@@ -0,0 +1,49 @@
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
+# RUN: llc -mtriple=aarch64-unknown-linux-gnu -run-pass=greedy,machinelicm -verify-machineinstrs -debug -o - %s | FileCheck %s
+
+# FIXME: Running RA is needed otherwise it runs pre-RA LICM.
+---
+name: test
+tracksRegLiveness: true
+body: |
+  ; CHECK-LABEL: name: test
+  ; CHECK: bb.0:
+  ; CHECK-NEXT:   successors: %bb.1(0x80000000)
+  ; CHECK-NEXT:   liveins: $x0, $w1, $x2
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT:   B %bb.1
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT: bb.1:
+  ; CHECK-NEXT:   successors: %bb.1(0x40000000), %bb.2(0x40000000)
+  ; CHECK-NEXT:   liveins: $x0, $w1, $x2
+  ; CHECK-NEXT: {{  $}}
+  ; CHECK-NEXT:   renamable $q11 = MOVIv4i32 2, 8
+  ; CHECK-NEXT:   BL &memset, csr_aarch64_aapcs, implicit-def dead $lr, implicit $sp, implicit $x0, implicit $w1, implicit $x2, implicit-def $sp, implicit-def $x0
+  ; CHECK-NEXT:   renamable $q10 = MVNIv4i32 4, 0
----------------
jayfoad wrote:

OK so AArch64 registers work like this: `b10` aliases the low 8 bits of `h10` which aliases the low 16 bits of `s10` which aliases the low 32 bits of `d10` which aliases the low 64 bits of `q10` which aliases the low 128 bits of `z10`.

My suspicion is that TableGen only creates one regunit for all of these `*10` registers. If that's true then there's no way for regunit-based clobbering info to express that `d10` is preserved but `q10` is not (because its high bits are clobbered). So I think we would have to go back and revert #94608.

https://github.com/llvm/llvm-project/pull/95926


More information about the llvm-commits mailing list