[llvm] 66aa260 - [gn] port 8b0d38be9ece414

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 04:38:16 PDT 2024


Author: Nico Weber
Date: 2024-06-18T07:38:05-04:00
New Revision: 66aa26012bda48bca58673fcdd0bed43380d544f

URL: https://github.com/llvm/llvm-project/commit/66aa26012bda48bca58673fcdd0bed43380d544f
DIFF: https://github.com/llvm/llvm-project/commit/66aa26012bda48bca58673fcdd0bed43380d544f.diff

LOG: [gn] port 8b0d38be9ece414

Added: 
    

Modified: 
    llvm/utils/gn/secondary/llvm/test/BUILD.gn

Removed: 
    llvm/utils/gn/secondary/llvm/lib/Transforms/Hello/BUILD.gn


################################################################################
diff  --git a/llvm/utils/gn/secondary/llvm/lib/Transforms/Hello/BUILD.gn b/llvm/utils/gn/secondary/llvm/lib/Transforms/Hello/BUILD.gn
deleted file mode 100644
index a55d956ac3b62..0000000000000
--- a/llvm/utils/gn/secondary/llvm/lib/Transforms/Hello/BUILD.gn
+++ /dev/null
@@ -1,26 +0,0 @@
-import("//llvm/utils/gn/build/symbol_exports.gni")
-
-assert(host_os != "win", "loadable modules not supported on win")
-
-symbol_exports("exports") {
-  exports_file = "Hello.exports"
-}
-
-loadable_module("Hello") {
-  output_name = "LLVMHello"
-  deps = [
-    ":exports",
-
-    # LLVMHello doesn't want to link in any LLVM code, it just
-    # needs its headers.
-    "//llvm/include/llvm/IR:public_tablegen",
-  ]
-  sources = [ "Hello.cpp" ]
-
-  if (host_os != "mac" && host_os != "win") {
-    # The GN build currently doesn't globally pass -fPIC, but that's
-    # needed for building .so files on ELF.  Just pass it manually
-    # for loadable_modules for now.
-    cflags = [ "-fPIC" ]
-  }
-}

diff  --git a/llvm/utils/gn/secondary/llvm/test/BUILD.gn b/llvm/utils/gn/secondary/llvm/test/BUILD.gn
index 4206489f39368..945fb0e922c9e 100644
--- a/llvm/utils/gn/secondary/llvm/test/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/test/BUILD.gn
@@ -343,10 +343,7 @@ group("test") {
     # loadable_modules don't work on Windows.
     # FIXME: In the CMake build, ENABLE_SHARED makes them work somehow
     # (but they're off by default there too).
-    deps += [
-      "//llvm/lib/Transforms/Hello",
-      "//llvm/tools/bugpoint-passes",
-    ]
+    deps += [ "//llvm/tools/bugpoint-passes" ]
   }
 
   # FIXME: llvm_build_examples


        


More information about the llvm-commits mailing list