[llvm] [llvm] Do not use Console API if the output isn't a console device (PR #90230)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 00:02:26 PDT 2024


mstorsjo wrote:

> I think this is a good idea. But it would need a release note. Does it need a test of some kind? To make sure the fallback to console api works maybe?

Some sort of automated test would certainly be good, but I'm not really sure how doable that is in our test infrastructure. (I would expect that all test executions are towards something that isn't directly a console, etc.) So I think it's fine without one... But bonus points for a sequence of easy instructions for verifying that it works, that anyone can repeat both now and when looking into related things in the future.

https://github.com/llvm/llvm-project/pull/90230


More information about the llvm-commits mailing list