[llvm] d6b0b7a - [ProfileData] Remove getValueProfDataFromInst (#95617)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 18:50:11 PDT 2024
Author: Kazu Hirata
Date: 2024-06-17T18:50:08-07:00
New Revision: d6b0b7acf3562c8089f3342634a749f03909fd32
URL: https://github.com/llvm/llvm-project/commit/d6b0b7acf3562c8089f3342634a749f03909fd32
DIFF: https://github.com/llvm/llvm-project/commit/d6b0b7acf3562c8089f3342634a749f03909fd32.diff
LOG: [ProfileData] Remove getValueProfDataFromInst (#95617)
I've migrated all uses to the new version of getValueProfDataFromInst
that returns std::unique_ptr<InstrProfValueData[]>.
Added:
Modified:
llvm/include/llvm/ProfileData/InstrProf.h
llvm/lib/ProfileData/InstrProf.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/ProfileData/InstrProf.h b/llvm/include/llvm/ProfileData/InstrProf.h
index 76002cdf565f2..c8ad42442cb31 100644
--- a/llvm/include/llvm/ProfileData/InstrProf.h
+++ b/llvm/include/llvm/ProfileData/InstrProf.h
@@ -284,16 +284,6 @@ void annotateValueSite(Module &M, Instruction &Inst,
ArrayRef<InstrProfValueData> VDs, uint64_t Sum,
InstrProfValueKind ValueKind, uint32_t MaxMDCount);
-/// Extract the value profile data from \p Inst which is annotated with
-/// value profile meta data. Return false if there is no value data annotated,
-/// otherwise return true.
-bool getValueProfDataFromInst(const Instruction &Inst,
- InstrProfValueKind ValueKind,
- uint32_t MaxNumValueData,
- InstrProfValueData ValueData[],
- uint32_t &ActualNumValueData, uint64_t &TotalC,
- bool GetNoICPValue = false);
-
/// Extract the value profile data from \p Inst and returns them if \p Inst is
/// annotated with value profile data. Returns nullptr otherwise. It's similar
/// to `getValueProfDataFromInst` above except that an array is allocated only
diff --git a/llvm/lib/ProfileData/InstrProf.cpp b/llvm/lib/ProfileData/InstrProf.cpp
index a0662a5976bbe..8cc1625e1c05c 100644
--- a/llvm/lib/ProfileData/InstrProf.cpp
+++ b/llvm/lib/ProfileData/InstrProf.cpp
@@ -1381,22 +1381,6 @@ getValueProfDataFromInst(const Instruction &Inst, InstrProfValueKind ValueKind,
return ValueDataArray;
}
-// FIXME: Migrate existing callers to the function above that returns an
-// array.
-bool getValueProfDataFromInst(const Instruction &Inst,
- InstrProfValueKind ValueKind,
- uint32_t MaxNumValueData,
- InstrProfValueData ValueData[],
- uint32_t &ActualNumValueData, uint64_t &TotalC,
- bool GetNoICPValue) {
- MDNode *MD = mayHaveValueProfileOfKind(Inst, ValueKind);
- if (!MD)
- return false;
- return getValueProfDataFromInstImpl(MD, MaxNumValueData, ValueData,
- ActualNumValueData, TotalC,
- GetNoICPValue);
-}
-
MDNode *getPGOFuncNameMetadata(const Function &F) {
return F.getMetadata(getPGOFuncNameMetadataName());
}
More information about the llvm-commits
mailing list