[llvm] 6b54ecc - [mlgo] remove `inlining_default` - unused feature

[Mircea Trofin via llvm-commits]

Author: Mircea Trofin
Date: 2024-06-17T14:42:10-07:00
New Revision: 6b54ecca885f58cd9449535a8678d93144c62e4d

URL: https://github.com/llvm/llvm-project/commit/6b54ecca885f58cd9449535a8678d93144c62e4d
DIFF: https://github.com/llvm/llvm-project/commit/6b54ecca885f58cd9449535a8678d93144c62e4d.diff

LOG: [mlgo] remove `inlining_default` - unused feature

The feature was only exposed for training and was immediately dropped on
the training side. It was bulk-copied into the test model generator, where
it had no effect (the generator always returns a constant).

In the AOT + test model case, since the test model returns a constant, all
input features are pruned by the AOT compiler, so its presence/absence
doesn't matter.

Added: 
    

Modified: 
    llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
    llvm/lib/Analysis/models/gen-inline-oz-test-model.py

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp b/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
index 7d51302bcc1ad..3ab0af8d57da1 100644
--- a/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
+++ b/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
@@ -253,7 +253,6 @@ class LoggingMLInlineAdvice : public MLInlineAdvice {
 };
 
 static const std::vector<TensorSpec> TrainingOnlyFeatures{
-    TensorSpec::createSpec<int64_t>(TFFeedPrefix + "inlining_default", {1}),
     TensorSpec::createSpec<float>(TFFeedPrefix + "discount", {1}),
     TensorSpec::createSpec<float>(TFFeedPrefix + "reward", {1}),
     TensorSpec::createSpec<int32_t>(TFFeedPrefix + "step_type", {1})};

diff  --git a/llvm/lib/Analysis/models/gen-inline-oz-test-model.py b/llvm/lib/Analysis/models/gen-inline-oz-test-model.py
index 83055890283e8..3846e7a3cee76 100644
--- a/llvm/lib/Analysis/models/gen-inline-oz-test-model.py
+++ b/llvm/lib/Analysis/models/gen-inline-oz-test-model.py
@@ -47,7 +47,6 @@ def get_input_signature():
             "edge_count",
             "callsite_height",
             "cost_estimate",
-            "inlining_default",
             "sroa_savings",
             "sroa_losses",
             "load_elimination",