[clang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

Tomas Matheson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 09:20:55 PDT 2024


================
@@ -114,12 +114,14 @@ using ExtensionBitset = Bitset<AEK_NUM_EXTENSIONS>;
 // SubtargetFeature which may represent either an actual extension or some
 // internal LLVM property.
 struct ExtensionInfo {
-  StringRef Name;                 // Human readable name, e.g. "profile".
+  StringRef UserVisibleName;      // Human readable name used in -march/-cpu, e.g. "profile"
   std::optional<StringRef> Alias; // An alias for this extension, if one exists.
   ArchExtKind ID;                 // Corresponding to the ArchExtKind, this
                                   // extensions representation in the bitfield.
-  StringRef Feature;              // -mattr enable string, e.g. "+spe"
-  StringRef NegFeature;           // -mattr disable string, e.g. "-spe"
+  StringRef ArchFeatureName;      // The feature name defined by the Architecture
+  StringRef Description;          // The textual description of the extension
+  StringRef TargetFeature;        // -target-feature/-mattr enable string, e.g. "+spe"
----------------
tmatheson-arm wrote:

```suggestion
  StringRef PosTargetFeature;        // -target-feature/-mattr enable string, e.g. "+spe"
```
Keeps it consistent with `NegTargetFeature`, and makes it clear it includes the `+`

https://github.com/llvm/llvm-project/pull/95805


More information about the llvm-commits mailing list