[lld] [llvm] [LLD][COFF] Add support for ARM64EC entry thunks. (PR #88132)

via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 08:18:04 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff a2bdbc6f0da2a9d0cecb23c64bd20423b3fd0340 d43f53d64f19c1b6ac5d3bf0da0ce01e0b4847cf -- lld/COFF/Chunks.cpp lld/COFF/Chunks.h lld/COFF/Driver.cpp lld/COFF/ICF.cpp lld/COFF/InputFiles.cpp lld/COFF/InputFiles.h lld/COFF/MarkLive.cpp lld/COFF/SymbolTable.cpp lld/COFF/SymbolTable.h lld/COFF/Writer.cpp llvm/include/llvm/BinaryFormat/COFF.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lld/COFF/SymbolTable.cpp b/lld/COFF/SymbolTable.cpp
index 1134103371..6cdd824cfd 100644
--- a/lld/COFF/SymbolTable.cpp
+++ b/lld/COFF/SymbolTable.cpp
@@ -571,9 +571,9 @@ void SymbolTable::initializeEntryThunks() {
     if (!to)
       continue;
     auto *from = dyn_cast<DefinedRegular>(it.first);
-    // We need to be able to add padding to the function and fill it with an offset
-    // to its entry thunks. To ensure that padding the function is feasible,
-    // functions are required to be COMDAT symbols with no offset.
+    // We need to be able to add padding to the function and fill it with an
+    // offset to its entry thunks. To ensure that padding the function is
+    // feasible, functions are required to be COMDAT symbols with no offset.
     if (!from || !from->getChunk()->isCOMDAT() ||
         cast<DefinedRegular>(from)->getValue()) {
       error("non COMDAT symbol '" + from->getName() + "' in hybrid map");

``````````

</details>


https://github.com/llvm/llvm-project/pull/88132


More information about the llvm-commits mailing list