[llvm] [AMDGPU] NFC: Remove duplicate VOP_DPP_Pseudo TableGen definitions (PR #95370)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 01:24:27 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Scott Egerton (ScottEgerton)
<details>
<summary>Changes</summary>
After recent changes, VOP_DPP_Pseudo now inherits from VOP_Pseudo.
This commit removes some on the duplicate definitions in
VOP_DPP_Pseudo that are exactly the same as definitions inherited from
VOP_Pseudo.
---
Full diff: https://github.com/llvm/llvm-project/pull/95370.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/VOPInstructions.td (-7)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/VOPInstructions.td b/llvm/lib/Target/AMDGPU/VOPInstructions.td
index eb260610e37ff..2b05165cc94bc 100644
--- a/llvm/lib/Target/AMDGPU/VOPInstructions.td
+++ b/llvm/lib/Target/AMDGPU/VOPInstructions.td
@@ -831,13 +831,9 @@ class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
dag Ins = P.InsDPP, string asmOps = P.AsmDPP> :
VOP_Pseudo<OpName, "_dpp", P, P.OutsDPP, Ins, asmOps, pattern> {
- let isPseudo = 1;
- let isCodeGenOnly = 1;
-
let mayLoad = 0;
let mayStore = 0;
let hasSideEffects = 0;
- let UseNamedOperandTable = 1;
let VALU = 1;
let DPP = 1;
@@ -850,7 +846,6 @@ class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
let Uses = !if(ReadsModeReg, [MODE, EXEC], [EXEC]);
let isConvergent = 1;
- string Mnemonic = OpName;
string AsmOperands = asmOps;
let AsmMatchConverter = !if(P.HasModifiers, "cvtDPP", "");
@@ -863,8 +858,6 @@ class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
let IsInvalidSingleUseConsumer = !not(VINTERP);
let IsInvalidSingleUseProducer = !not(VINTERP);
-
- VOPProfile Pfl = P;
}
class VOP3_DPP_Pseudo <string OpName, VOPProfile P> :
``````````
</details>
https://github.com/llvm/llvm-project/pull/95370
More information about the llvm-commits
mailing list