[llvm] [AMDGPU] NFC: Remove duplicate VOP_DPP_Pseudo TableGen definitions (PR #95370)
Scott Egerton via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 01:23:55 PDT 2024
https://github.com/ScottEgerton created https://github.com/llvm/llvm-project/pull/95370
After recent changes, VOP_DPP_Pseudo now inherits from VOP_Pseudo.
This commit removes some on the duplicate definitions in
VOP_DPP_Pseudo that are exactly the same as definitions inherited from
VOP_Pseudo.
>From 345a9ce889e1281ee8b65e2b663891afbe6fda80 Mon Sep 17 00:00:00 2001
From: Scott Egerton <scott.egerton at amd.com>
Date: Wed, 12 Jun 2024 14:50:13 +0100
Subject: [PATCH] [AMDGPU] NFC: Remove duplicate VOP_DPP_Pseudo TableGen
definitions
After recent changes, VOP_DPP_Pseudo now inherits from VOP_Pseudo.
This commit removes some on the duplicate definitions in
VOP_DPP_Pseudo that are exactly the same as definitions inherited from
VOP_Pseudo.
---
llvm/lib/Target/AMDGPU/VOPInstructions.td | 7 -------
1 file changed, 7 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/VOPInstructions.td b/llvm/lib/Target/AMDGPU/VOPInstructions.td
index eb260610e37ff..2b05165cc94bc 100644
--- a/llvm/lib/Target/AMDGPU/VOPInstructions.td
+++ b/llvm/lib/Target/AMDGPU/VOPInstructions.td
@@ -831,13 +831,9 @@ class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
dag Ins = P.InsDPP, string asmOps = P.AsmDPP> :
VOP_Pseudo<OpName, "_dpp", P, P.OutsDPP, Ins, asmOps, pattern> {
- let isPseudo = 1;
- let isCodeGenOnly = 1;
-
let mayLoad = 0;
let mayStore = 0;
let hasSideEffects = 0;
- let UseNamedOperandTable = 1;
let VALU = 1;
let DPP = 1;
@@ -850,7 +846,6 @@ class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
let Uses = !if(ReadsModeReg, [MODE, EXEC], [EXEC]);
let isConvergent = 1;
- string Mnemonic = OpName;
string AsmOperands = asmOps;
let AsmMatchConverter = !if(P.HasModifiers, "cvtDPP", "");
@@ -863,8 +858,6 @@ class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
let IsInvalidSingleUseConsumer = !not(VINTERP);
let IsInvalidSingleUseProducer = !not(VINTERP);
-
- VOPProfile Pfl = P;
}
class VOP3_DPP_Pseudo <string OpName, VOPProfile P> :
More information about the llvm-commits
mailing list