[llvm] [llvm][lit] Remove unused default feature (PR #94804)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 14:41:48 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-testing-tools

Author: Keith Smiley (keith)

<details>
<summary>Changes</summary>

It looks like this FIXME was resolved when the last use of this was
removed in 085f078307bac264301b07f6e47e2a04e90a6f1d


---
Full diff: https://github.com/llvm/llvm-project/pull/94804.diff


1 Files Affected:

- (modified) llvm/utils/lit/lit/llvm/config.py (-5) 


``````````diff
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index afb7f078072fc..30abb539d6647 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -88,14 +88,9 @@ def __init__(self, lit_config, config):
             ]
         )
 
-        # Running on Darwin OS
         if platform.system() == "Darwin":
-            # FIXME: lld uses the first, other projects use the second.
-            # We should standardize on the former.
-            features.add("system-linker-mach-o")
             features.add("system-darwin")
         elif platform.system() == "Windows":
-            # For tests that require Windows to run.
             features.add("system-windows")
         elif platform.system() == "Linux":
             features.add("system-linux")

``````````

</details>


https://github.com/llvm/llvm-project/pull/94804


More information about the llvm-commits mailing list