[llvm] [KnownBits] Remove `hasConflict()` assertions (PR #94568)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 08:51:56 PDT 2024


================
@@ -653,8 +656,10 @@ TEST(KnownBitsTest, GetMinMaxVal) {
       Min = APIntOps::umin(Min, N);
       Max = APIntOps::umax(Max, N);
     });
-    EXPECT_EQ(Min, Known.getMinValue());
-    EXPECT_EQ(Max, Known.getMaxValue());
+    if (!Known.hasConflict()) {
----------------
nikic wrote:

Hm, yes, I guess we should store Known.getMinValue() etc in a variable first, before the check. Or do people think there is not much value in checking all the functions with conflict inputs?

https://github.com/llvm/llvm-project/pull/94568


More information about the llvm-commits mailing list