[llvm] [KnownBits] Remove `hasConflict()` assertions (PR #94568)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 08:20:37 PDT 2024


================
@@ -653,8 +656,10 @@ TEST(KnownBitsTest, GetMinMaxVal) {
       Min = APIntOps::umin(Min, N);
       Max = APIntOps::umax(Max, N);
     });
-    EXPECT_EQ(Min, Known.getMinValue());
-    EXPECT_EQ(Max, Known.getMaxValue());
+    if (!Known.hasConflict()) {
----------------
jayfoad wrote:

But in this case you are not calling `Known.anything()` before checking for conflict and bailing out!

https://github.com/llvm/llvm-project/pull/94568


More information about the llvm-commits mailing list