[lld] [lld] Remove const qualifier on symbolKind (NFC) (PR #94753)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 06:20:15 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-platform-windows
@llvm/pr-subscribers-lld-coff

@llvm/pr-subscribers-lld

Author: Nikita Popov (nikic)

<details>
<summary>Changes</summary>

The symbol including this member is being overwritten here: https://github.com/llvm/llvm-project/blob/2117677e304d334326f6591f3c75fb2f34dc4bcb/lld/COFF/SymbolTable.cpp#L496-L509 I don't think that's compatible with this `const` qualifier.

---
Full diff: https://github.com/llvm/llvm-project/pull/94753.diff


1 Files Affected:

- (modified) lld/COFF/Symbols.h (+1-1) 


``````````diff
diff --git a/lld/COFF/Symbols.h b/lld/COFF/Symbols.h
index ca69fb2d05270..5ef46f5af6a6c 100644
--- a/lld/COFF/Symbols.h
+++ b/lld/COFF/Symbols.h
@@ -106,7 +106,7 @@ class Symbol {
            "If the name is empty, the Symbol must be a DefinedCOFF.");
   }
 
-  const unsigned symbolKind : 8;
+  unsigned symbolKind : 8;
   unsigned isExternal : 1;
 
 public:

``````````

</details>


https://github.com/llvm/llvm-project/pull/94753


More information about the llvm-commits mailing list