[lld] [lld] Remove const qualifier on symbolKind (NFC) (PR #94753)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 06:19:45 PDT 2024


https://github.com/nikic created https://github.com/llvm/llvm-project/pull/94753

The symbol including this member is being overwritten here: https://github.com/llvm/llvm-project/blob/2117677e304d334326f6591f3c75fb2f34dc4bcb/lld/COFF/SymbolTable.cpp#L496-L509 I don't think that's compatible with this `const` qualifier.

>From 5b8e0f811a68e6627f1c7681802a9d52b068ee44 Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Fri, 7 Jun 2024 15:16:56 +0200
Subject: [PATCH] [lld] Remove const qualifier on symbolKind (NFC)

The symbol including this member is being overwritten here:
https://github.com/llvm/llvm-project/blob/2117677e304d334326f6591f3c75fb2f34dc4bcb/lld/COFF/SymbolTable.cpp#L496-L509
---
 lld/COFF/Symbols.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lld/COFF/Symbols.h b/lld/COFF/Symbols.h
index ca69fb2d05270..5ef46f5af6a6c 100644
--- a/lld/COFF/Symbols.h
+++ b/lld/COFF/Symbols.h
@@ -106,7 +106,7 @@ class Symbol {
            "If the name is empty, the Symbol must be a DefinedCOFF.");
   }
 
-  const unsigned symbolKind : 8;
+  unsigned symbolKind : 8;
   unsigned isExternal : 1;
 
 public:



More information about the llvm-commits mailing list