[llvm] [SCEV] Add predicated version of getSymbolicMaxBackedgeTakenCount. (PR #93498)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 06:17:04 PDT 2024


================
@@ -8644,9 +8649,9 @@ ScalarEvolution::BackedgeTakenInfo::getConstantMax(ScalarEvolution *SE) const {
   return getConstantMax();
 }
 
-const SCEV *
-ScalarEvolution::BackedgeTakenInfo::getSymbolicMax(const Loop *L,
-                                                   ScalarEvolution *SE) {
+const SCEV *ScalarEvolution::BackedgeTakenInfo::getSymbolicMax(
----------------
fhahn wrote:

You are right, this should have been referenced, apologies for that! To rectify that, how about reverting the patch and then recommitting with an adjusted message to include an attribution like

```
The extension of getSymbolicMax to support predication is inspired by David Sherwood's (@david-arm) version in https://github.com/llvm/llvm-project/pull/88385
```

Happy to adjust as needed, if you think a different wording would be better


https://github.com/llvm/llvm-project/pull/93498


More information about the llvm-commits mailing list