[llvm] [SCEV] Add predicated version of getSymbolicMaxBackedgeTakenCount. (PR #93498)

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 05:51:06 PDT 2024


================
@@ -8644,9 +8649,9 @@ ScalarEvolution::BackedgeTakenInfo::getConstantMax(ScalarEvolution *SE) const {
   return getConstantMax();
 }
 
-const SCEV *
-ScalarEvolution::BackedgeTakenInfo::getSymbolicMax(const Loop *L,
-                                                   ScalarEvolution *SE) {
+const SCEV *ScalarEvolution::BackedgeTakenInfo::getSymbolicMax(
----------------
david-arm wrote:

Perhaps I'm wrong but this change looks to have taken inspiration (and a little code) from https://github.com/llvm/llvm-project/pull/88385.  I'm happy for the collaboration but LLVM rules suggest it would have been polite to reference my PR or indicate co-authorship?

https://github.com/llvm/llvm-project/pull/93498


More information about the llvm-commits mailing list