[llvm] [llvm-objdump] Don't match directory prefix in source-interleave test (NFC) (PR #93789)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 01:51:13 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-binary-utilities

Author: Nikita Popov (nikic)

<details>
<summary>Changes</summary>

This test currently has an explicit regex for characters that are supposedly valid inside a directory name -- however, it does not actually cover all necessary characters. For example, this test fails if the path contains a tilde.

Instead, replace this with a wildcard.

---
Full diff: https://github.com/llvm/llvm-project/pull/93789.diff


1 Files Affected:

- (modified) llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test (+1-1) 


``````````diff
diff --git a/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test b/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
index cbcc35cf79653..dcce95c83b1d2 100644
--- a/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
+++ b/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
@@ -11,7 +11,7 @@
 
 # LINES: <main>:
 # LINES-NEXT: ; main():
-# LINES-NEXT: ; {{[ -\(\)_A-Za-z0-9.\\/:]+}}source-interleave-x86_64.c:6
+# LINES-NEXT: ; {{.+}}source-interleave-x86_64.c:6
 
 # SOURCE: <main>:
 # SOURCE-NEXT: ; int main() {

``````````

</details>


https://github.com/llvm/llvm-project/pull/93789


More information about the llvm-commits mailing list