[llvm] [llvm-objdump] Don't match directory prefix in source-interleave test (NFC) (PR #93789)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Thu May 30 01:50:41 PDT 2024
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/93789
This test currently has an explicit regex for characters that are supposedly valid inside a directory name -- however, it does not actually cover all necessary characters. For example, this test fails if the path contains a tilde.
Instead, replace this with a wildcard.
>From 460163fe4cbd22ac570794b3237b364072804148 Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Thu, 30 May 2024 10:46:35 +0200
Subject: [PATCH] [llvm-objdump] Don't match directory prefix in
source-interleave test (NFC)
This test currently has an explicit regex for characters that are
supposedly valid inside a directory name -- however, it does not
actually cover all necessary characters. For example, this test
fails if the path contains a tilde.
Instead, replace this with a wildcard.
---
llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test b/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
index cbcc35cf79653..dcce95c83b1d2 100644
--- a/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
+++ b/llvm/test/tools/llvm-objdump/X86/source-interleave-x86_64.test
@@ -11,7 +11,7 @@
# LINES: <main>:
# LINES-NEXT: ; main():
-# LINES-NEXT: ; {{[ -\(\)_A-Za-z0-9.\\/:]+}}source-interleave-x86_64.c:6
+# LINES-NEXT: ; {{.+}}source-interleave-x86_64.c:6
# SOURCE: <main>:
# SOURCE-NEXT: ; int main() {
More information about the llvm-commits
mailing list