[llvm] dbfed77 - [WindowsManifestMerger] Remove deprecated call to xmlKeepBlanksDefault (#93139)

via llvm-commits llvm-commits at lists.llvm.org
Sun May 26 23:48:38 PDT 2024


Author: Nikita Popov
Date: 2024-05-27T08:48:33+02:00
New Revision: dbfed77a47c59cfca5147d5e62a52df4c597ba10

URL: https://github.com/llvm/llvm-project/commit/dbfed77a47c59cfca5147d5e62a52df4c597ba10
DIFF: https://github.com/llvm/llvm-project/commit/dbfed77a47c59cfca5147d5e62a52df4c597ba10.diff

LOG: [WindowsManifestMerger] Remove deprecated call to xmlKeepBlanksDefault (#93139)

This function has been deprecated in favor of the XML_PARSE_NOBLANKS
option. The code already uses the option, so remove the call. If this
call served some additional purpose, then it wasn't tested.

Fixes https://github.com/llvm/llvm-project/issues/86029.

Added: 
    

Modified: 
    llvm/lib/WindowsManifest/WindowsManifestMerger.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp b/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
index 8f5c53faf91e2..b59b666ce04f9 100644
--- a/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
+++ b/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
@@ -669,7 +669,6 @@ WindowsManifestMerger::WindowsManifestMergerImpl::getMergedManifest() {
     xmlDocSetRootElement(OutputDoc.get(), CombinedRoot);
     assert(nullptr == xmlDocGetRootElement(CombinedDoc));
 
-    xmlKeepBlanksDefault(0);
     xmlChar *Buff = nullptr;
     xmlDocDumpFormatMemoryEnc(OutputDoc.get(), &Buff, &BufferSize, "UTF-8", 1);
     Buffer.reset(Buff);


        


More information about the llvm-commits mailing list