[llvm] 5b14624 - [X86][DAGCombine] Remove the predicate hasCCMP() in combineX86SubCmpForFlags, NFCI

[Shengchen Kan via llvm-commits]

Author: Shengchen Kan
Date: 2024-05-27T12:53:31+08:00
New Revision: 5b146246c4dcb3eb903199144cfd63f4dbc8bf26

URL: https://github.com/llvm/llvm-project/commit/5b146246c4dcb3eb903199144cfd63f4dbc8bf26
DIFF: https://github.com/llvm/llvm-project/commit/5b146246c4dcb3eb903199144cfd63f4dbc8bf26.diff

LOG: [X86][DAGCombine] Remove the predicate hasCCMP() in combineX86SubCmpForFlags, NFCI

No update for non-APX tests.

This patch resolves TODO in #91747.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 0e514ca1246b0..1a9b215787e10 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -49239,8 +49239,7 @@ static SDValue combineX86SubCmpForFlags(SDNode *N, SDValue Flag,
 
   SDValue SetCC = N->getOperand(0);
 
-  // TODO: Remove the check hasCCMP() and update the non-APX tests.
-  if (!ST.hasCCMP() || SetCC.getOpcode() != X86ISD::SETCC || !Flag.hasOneUse())
+  if (SetCC.getOpcode() != X86ISD::SETCC || !Flag.hasOneUse())
     return SDValue();
 
   // Check the only user of flag is `brcond ne`.