[clang] [llvm] [WebAssembly] Refactor Wasm Reference Types as TargetExtType (PR #93428)
via llvm-commits
llvm-commits at lists.llvm.org
Sun May 26 14:32:45 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff faef8b4aa245a671e2013319e8073a9fc52ae12e e79363aed798ce22f408fea3c283bb7d6387535a -- clang/test/CodeGen/WebAssembly/builtins-table.c clang/test/CodeGen/WebAssembly/wasm-externref.c clang/test/CodeGen/WebAssembly/wasm-funcref.c clang/test/CodeGen/builtins-wasm.c llvm/include/llvm/IR/Intrinsics.h llvm/lib/CodeGen/ValueTypes.cpp llvm/lib/IR/Function.cpp llvm/lib/IR/Type.cpp llvm/lib/Target/WebAssembly/Utils/WasmAddressSpaces.h llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.h llvm/lib/Target/WebAssembly/WebAssembly.h llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/IR/Function.cpp b/llvm/lib/IR/Function.cpp
index 40964c7a33..718b0e55a2 100644
--- a/llvm/lib/IR/Function.cpp
+++ b/llvm/lib/IR/Function.cpp
@@ -1556,10 +1556,10 @@ static bool matchIntrinsicType(
cast<TargetExtType>(Ty)->getName() != "aarch64.svcount";
case IITDescriptor::WasmExternref:
return !isa<TargetExtType>(Ty) ||
- cast<TargetExtType>(Ty)->getName() != "wasm.externref";
+ cast<TargetExtType>(Ty)->getName() != "wasm.externref";
case IITDescriptor::WasmFuncref:
return !isa<TargetExtType>(Ty) ||
- cast<TargetExtType>(Ty)->getName() != "wasm.funcref";
+ cast<TargetExtType>(Ty)->getName() != "wasm.funcref";
case IITDescriptor::Vector: {
VectorType *VT = dyn_cast<VectorType>(Ty);
return !VT || VT->getElementCount() != D.Vector_Width ||
diff --git a/llvm/lib/IR/Type.cpp b/llvm/lib/IR/Type.cpp
index 3fdc4310a8..edffd04a01 100644
--- a/llvm/lib/IR/Type.cpp
+++ b/llvm/lib/IR/Type.cpp
@@ -845,7 +845,8 @@ static TargetTypeInfo getTargetTypeInfo(const TargetExtType *Ty) {
// Opaque types in the WebAssembly name space.
if (Name.starts_with("wasm."))
- return TargetTypeInfo(PointerType::getUnqual(C), TargetExtType::HasZeroInit, TargetExtType::CanBeGlobal);
+ return TargetTypeInfo(PointerType::getUnqual(C), TargetExtType::HasZeroInit,
+ TargetExtType::CanBeGlobal);
return TargetTypeInfo(Type::getVoidTy(C));
}
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
index b640467cbc..668942c0b9 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
@@ -1243,8 +1243,7 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo &CLI,
SDValue TableSetOps[] = {Chain, Sym, TableSlot, Callee};
SDValue TableSet = DAG.getMemIntrinsicNode(
WebAssemblyISD::TABLE_SET, DL, DAG.getVTList(MVT::Other), TableSetOps,
- MVT::funcref,
- MachinePointerInfo(),
+ MVT::funcref, MachinePointerInfo(),
CLI.CB->getCalledOperand()->getPointerAlignment(DAG.getDataLayout()),
MachineMemOperand::MOStore);
``````````
</details>
https://github.com/llvm/llvm-project/pull/93428
More information about the llvm-commits
mailing list