[llvm] [X86][CodeGen] Support lowering for CCMP/CTEST (PR #91747)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Sun May 26 11:24:54 PDT 2024


================
@@ -1801,11 +1801,8 @@ void DAGCombiner::Run(CombineLevel AtLevel) {
 
     if (N->getNumValues() == RV->getNumValues())
       DAG.ReplaceAllUsesWith(N, RV.getNode());
-    else {
-      assert(N->getValueType(0) == RV.getValueType() &&
-             N->getNumValues() == 1 && "Type mismatch");
----------------
s-barannikov wrote:

> Yes, we need. After changing SUB to CCMP, neither of them satisfy.

This means that there is a problem in combining SUB to CCMP. The assert here is to catch such kind of errors.
See my other comment.

https://github.com/llvm/llvm-project/pull/91747


More information about the llvm-commits mailing list