[llvm] [LAA] refactor program logic (NFC) (PR #92101)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 03:32:39 PDT 2024


fhahn wrote:

> FWIW, I don't agree with @fhahn and every time a merge commit is introduced in a PR is a big annoyance to me. Please do prefer rebase, just avoid also squashing commits at the same time.

Hmm, looking back the link I shared, it seems the recommendation is to not update the PR at all (also no merge) unless absolutely necessary. Also looking back at the discussion, there doesn't seem to be a very clear consensus either way.

 It's a shame that GH doesn't handle this better, e.g. it is not possible the view the earlier code comments in that PR in the code view (https://github.com/llvm/llvm-project/pull/92101/files#diff-4fcef9d109d67042b3c7d8d5a005ace05d1a0ac7e6cdee8dec106352c1dd8447) but I guess  it is something we have to live with now

https://github.com/llvm/llvm-project/pull/92101


More information about the llvm-commits mailing list