[llvm] [SPIR-V] Enable spirv-val in SPV_KHR_shader_clock test (PR #93292)
Sven van Haastregt via llvm-commits
llvm-commits at lists.llvm.org
Fri May 24 03:32:11 PDT 2024
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/93292
Validation succeeds on this test since SPIRV-Tools commit `e2646f5e ("spirv-val: Consider target env for OpReadClockKHR scope", 2024-05-21)`.
>From e06fc4f378cd37f51077cf3581e7f01e0d8c6080 Mon Sep 17 00:00:00 2001
From: Sven van Haastregt <sven.vanhaastregt at arm.com>
Date: Fri, 24 May 2024 10:50:55 +0100
Subject: [PATCH] [SPIR-V] Enable spirv-val in SPV_KHR_shader_clock test
Validation succeeds on this test since SPIRV-Tools commit e2646f5e
("spirv-val: Consider target env for OpReadClockKHR scope (#5681)",
2024-05-21).
---
.../SPIRV/extensions/SPV_KHR_shader_clock/shader_clock.ll | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_shader_clock/shader_clock.ll b/llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_shader_clock/shader_clock.ll
index f20c1667421e7..e219f61b5c6e3 100644
--- a/llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_shader_clock/shader_clock.ll
+++ b/llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_shader_clock/shader_clock.ll
@@ -1,6 +1,6 @@
; RUN: not llc -O0 -mtriple=spirv64-unknown-unknown %s -o %t.spvt 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown --spirv-ext=+SPV_KHR_shader_clock %s -o - | FileCheck %s
-; TODO: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown --spirv-ext=+SPV_KHR_shader_clock %s -o - -filetype=obj | spirv-val %}
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown --spirv-ext=+SPV_KHR_shader_clock %s -o - -filetype=obj | spirv-val %}
; CHECK-ERROR: LLVM ERROR: clock_read_device: the builtin requires the following SPIR-V extension: SPV_KHR_shader_clock
More information about the llvm-commits
mailing list