[llvm] [RuntimeDyldChecker][AArch32] Add a PC offset to next_PC for ARM targets (PR #91746)

Eymen Ünay via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 03:05:15 PDT 2024


eymay wrote:

> Hey! Thanks for your proposal. I think it's valuable. Your [second patch](https://github.com/llvm/llvm-project/pull/91746/commits/0eecc0ab808b592ccd41aadc32b91a55d9f177d9) seemed very much to the point. Maybe with a more verbose comment like:
> 
> https://github.com/llvm/llvm-project/blob/142c89c381bccba1c688a90d7e9df91eaf78d4e3/llvm/test/ExecutionEngine/JITLink/AArch32/ELF_static_arm_reloc.s#L16-L17
> We could then clean up these comments in the tests. What do you think?

Thanks for the review! Sounds good, I was conservative with line estate as the checker deals with all targets but more explanation would not hurt definitely. 

https://github.com/llvm/llvm-project/pull/91746


More information about the llvm-commits mailing list