[llvm] [BOLT] add disable pass flags (PR #93032)

Rafael Auler via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 12:32:35 PDT 2024


================
@@ -269,9 +266,11 @@ Error ReorderFunctions::readFunctionOrderFile(
 }
 
 Error ReorderFunctions::runOnFunctions(BinaryContext &BC) {
+  if (opts::ReorderFunctions == RT_NONE) {
----------------
rafaelauler wrote:

I tried your change and it looks like there's quite a few tests failing because they depend on the behavior that is currently encoded (to run this logic even if we have RT_NONE). Perhaps this change is not as trivial and it seems we are overlooking some necessary steps here when we have RT_NONE.

If you want to check, you can run ninja check-bolt to see the tests that fail. I suggest we leave this as is and classify reorder functions as mandatory, even when no order is specified.

https://github.com/llvm/llvm-project/pull/93032


More information about the llvm-commits mailing list