[llvm] [llvm-profgen] Trim tail CR+LF for LBR record line (PR #93210)
Haohai Wen via llvm-commits
llvm-commits at lists.llvm.org
Thu May 23 09:03:40 PDT 2024
https://github.com/HaohaiWen created https://github.com/llvm/llvm-project/pull/93210
On Windows, perfscript generated by sep contains CR+LF at the end of
LBR records line. This '\r' will be treated as an LBR record and then
generate warning.
>From f006ccc0c3bfb2fa66b423d77de9325cd437e738 Mon Sep 17 00:00:00 2001
From: Haohai Wen <haohai.wen at intel.com>
Date: Thu, 23 May 2024 23:55:13 +0800
Subject: [PATCH] [llvm-profgen] Trim tail CR+LF for LBR record line
On Windows, perfscript generated by sep contains CR+LF at the end of
LBR records line. This '\r' will be treated as an LBR record and then
generate warning.
---
llvm/tools/llvm-profgen/PerfReader.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/tools/llvm-profgen/PerfReader.cpp b/llvm/tools/llvm-profgen/PerfReader.cpp
index e9442027aed3f..e63c6d61b3bfc 100644
--- a/llvm/tools/llvm-profgen/PerfReader.cpp
+++ b/llvm/tools/llvm-profgen/PerfReader.cpp
@@ -552,7 +552,7 @@ bool PerfScriptReader::extractLBRStack(TraceStream &TraceIt,
// ... 0x4005c8/0x4005dc/P/-/-/0
// It's in FIFO order and seperated by whitespace.
SmallVector<StringRef, 32> Records;
- TraceIt.getCurrentLine().split(Records, " ", -1, false);
+ TraceIt.getCurrentLine().rtrim().split(Records, " ", -1, false);
auto WarnInvalidLBR = [](TraceStream &TraceIt) {
WithColor::warning() << "Invalid address in LBR record at line "
<< TraceIt.getLineNumber() << ": "
More information about the llvm-commits
mailing list