[llvm] [X86][GlobalISel] Enable G_BUILD_VECTOR and G_CONSTANT_POOL (PR #92844)
Evgenii Kudriashov via llvm-commits
llvm-commits at lists.llvm.org
Thu May 23 08:17:02 PDT 2024
================
@@ -505,6 +505,9 @@ bool X86PassConfig::addRegBankSelect() {
bool X86PassConfig::addGlobalInstructionSelect() {
addPass(new InstructionSelect(getOptLevel()));
+ // Add GlobalBaseReg in case there is no SelectionDAG passes afterwards
+ if (isGlobalISelAbortEnabled())
----------------
e-kud wrote:
Yes, indeed, it mirrors the check from here
https://github.com/llvm/llvm-project/blob/82b95d0089bea67d1a06fa75d2a4b5e087563d6f/llvm/include/llvm/Passes/CodeGenPassBuilder.h#L836-L838
I think it would be better to create a new insert point in a separate PR?
https://github.com/llvm/llvm-project/pull/92844
More information about the llvm-commits
mailing list