[llvm] [Coroutines] Always set the calling convention of generated resuming call from 'llvm.coro.await.suspend.handle' as fast (PR #93167)

Chuanqi Xu via llvm-commits llvm-commits at lists.llvm.org
Thu May 23 07:30:55 PDT 2024


ChuanqiXu9 wrote:

> lgtm, thanks!
> 
> > We met a regression due to a change of calling convention of this patch.
> 
> How did you detect the regression? Was the resume call crashing due to mismatched calling convention? Did the verifier catch it?

No, it was an amazing double free segfault. I tried to reduce the case but it shows too hard. Then I tried to review the code second time and find this point luckily.

https://github.com/llvm/llvm-project/pull/93167


More information about the llvm-commits mailing list