[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu May 23 02:38:16 PDT 2024
================
@@ -392,6 +393,70 @@ ELFFile<ELFT>::decode_relrs(Elf_Relr_Range relrs) const {
return Relocs;
}
+template <class ELFT>
+uint64_t ELFFile<ELFT>::crelHeader(ArrayRef<uint8_t> Content) const {
+ DataExtractor Data(Content, true, 8); // endian/class is irrelevant
+ DataExtractor::Cursor Cur(0);
+ uint64_t Hdr = Data.getULEB128(Cur);
+ // In case of an error, return 0 and postpone error reporting to decodeCrel.
+ consumeError(Cur.takeError());
----------------
jh7370 wrote:
Throwing away the error like this means you lose the context about what went wrong when decoding. That doesn't seem great to me.
https://github.com/llvm/llvm-project/pull/91280
More information about the llvm-commits
mailing list